Adjustments of agency confirmation style#194
Merged
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/agency-design-improvements
branch
from
6b10dc3 to
5c7944b
Compare
…style Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Member
|
Looks nice! |
jancborchardt
approved these changes
Feb 25, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Wow @julien-nc, that looks super good already! :) If it is different options, "After 3" is the best.
Small point I don’t know if I mentioned in our call before: Usually we have the primary button on the right, and cancel on the left (or left of it). Could the buttons be switched around?
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Member
Author
|
@jancborchardt Thanks for the feedback! Buttons have been switched. New release incoming. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
After 2
After 3
For actions with a lot of params:
More will come.